| Conditions | 3 |
| Total Lines | 63 |
| Code Lines | 43 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import { Inject } from '@nestjs/common'; |
||
| 29 | |||
| 30 | public async execute(command: CreateLeaveRequestCommand): Promise<string> { |
||
| 31 | const { |
||
| 32 | user, |
||
| 33 | endDate, |
||
| 34 | endsAllDay, |
||
| 35 | type, |
||
| 36 | startDate, |
||
| 37 | startsAllDay, |
||
| 38 | comment |
||
| 39 | } = command; |
||
| 40 | |||
| 41 | if ( |
||
| 42 | true === |
||
| 43 | (await this.doesLeaveRequestExistForPeriod.isSatisfiedBy( |
||
| 44 | user, |
||
| 45 | startDate, |
||
| 46 | endDate |
||
| 47 | )) |
||
| 48 | ) { |
||
| 49 | throw new LeaveRequestAlreadyExistForThisPeriodException(); |
||
| 50 | } |
||
| 51 | |||
| 52 | if ( |
||
| 53 | true === |
||
| 54 | (await this.doesLeaveExistForPeriod.isSatisfiedBy( |
||
| 55 | user, |
||
| 56 | startDate, |
||
| 57 | endDate |
||
| 58 | )) |
||
| 59 | ) { |
||
| 60 | throw new EventsOrLeavesAlreadyExistForThisPeriodException(); |
||
| 61 | } |
||
| 62 | |||
| 63 | const leaveRequest = await this.leaveRequestRepository.save( |
||
| 64 | new LeaveRequest( |
||
| 65 | user, |
||
| 66 | type, |
||
| 67 | startDate, |
||
| 68 | startsAllDay, |
||
| 69 | endDate, |
||
| 70 | endsAllDay, |
||
| 71 | comment |
||
| 72 | ) |
||
| 73 | ); |
||
| 74 | |||
| 75 | this.commandBus.execute( |
||
| 76 | new CreateNotificationCommand( |
||
| 77 | NotificationType.POST, |
||
| 78 | this.translator.translate( |
||
| 79 | 'leave-requests-create-notification-message', |
||
| 80 | { |
||
| 81 | userFirstName: leaveRequest.getUser().getFirstName(), |
||
| 82 | link: `${this.configService.get<string>( |
||
| 83 | 'PERMACOOP_BASE_URL' |
||
| 84 | )}/app/people/leaves/${leaveRequest.getId()}` |
||
| 85 | } |
||
| 86 | ), |
||
| 87 | leaveRequest |
||
| 88 | ) |
||
| 89 | ); |
||
| 90 | |||
| 91 | return leaveRequest.getId(); |
||
| 92 | } |
||
| 94 |